Remove dup of index-state, no longer needed with latest haskell.nix #5026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbgi
requested review from
a team,
deepfire,
mgmeier,
fmaste,
dcoutts,
Jimbo4350,
erikd,
newhoggy,
JaredCorduan and
CarlosLopezDeLara
as code owners
jbgi
force-pushed
the
jbgi/no-dup-index-state
branch
3 times, most recently
from
c79a0ce to
7534b1d
Compare
|
Conflicts. |
jbgi
force-pushed
the
jbgi/no-dup-index-state
branch
2 times, most recently
from
0a7c95c to
fb8cb46
Compare
jbgi
force-pushed
the
jbgi/no-dup-index-state
branch
2 times, most recently
from
0211bbb to
dc11e44
Compare
deepfire
approved these changes
Apr 5, 2023
jbgi
force-pushed
the
jbgi/no-dup-index-state
branch
from
dc11e44 to
d35c4e6
Compare
which also requires using github project (instead of hackage) for hls.
jbgi
force-pushed
the
jbgi/no-dup-index-state
branch
from
d35c4e6 to
e97a004
Compare
newhoggy
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as of input-output-hk/haskell.nix#1903 haskell.nix (the nix part) does not parse the index-state so the duplication which was done for haskell.nix is no longer needed.
There is also a change to use hls from github (hence with access to the cabal.project) instead of hackage (which was breaking regularly), required due to input-output-hk/haskell.nix#1909