Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About Orchestrator #2

Open
skatsaounis opened this issue Mar 12, 2017 · 1 comment
Open

About Orchestrator #2

skatsaounis opened this issue Mar 12, 2017 · 1 comment

Comments

@skatsaounis
Copy link

Good evening,

Having implemented a solution with a dummy heuristic, I have encountered some minor issues with client object.

  1. orchestrator/python/main.py line 66:
    client = docker.from_env() should be client = docker.from_env().api

  2. client object should be passed to scaleUp and scaleDown functions as a parameter or declared as global

Please feel free to check my solution at my forked cna-hands.

P.S. I am very short on time to come up with a smart heuristic. If that happens I will commit my changes.

Kind regards,
Katsaounis Stamatis

@georgepar
Copy link
Member

Hey Stamatis,

Thank you for the fork / solution. I'll definitely check it out.

  1. The first issue you describe can also be resolved using APIClient.

  2. Thanks :). Fixed

BR,
George

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants