Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes the verbose logging so that it doesn't leak tokens #130

Merged
merged 1 commit into from
Jan 4, 2019

Conversation

orta
Copy link
Contributor

@orta orta commented Jan 4, 2019

What Changed

While debugging, I wanted to run with --verbose to see what was up. Unfortunately, this leaked my GH token to the public. Which was fine because I was reading my logs carefully, but better to just not let it happen. This amends logging

ℹ  info      Initializing GitHub API with:
 { owner: 'artsy',
  repo: 'reaction',
  version: '9.1.56',
  logger:
   { log:
      Signale {
        _interactive: false,
        _config: [Object],
        log: [Function: bound _logger] },
     verbose:
      Signale {
        _interactive: false,
        log: [Function: bound _logger] },
     veryVerbose:
      Signale {
        _interactive: false,
        log: [Function: bound _logger] } },
  token: '[Real token]',
  baseUrl: 'https://api.github.com' }

Now it will just show the first 4 chars.

this.logger.verbose.info(
'Initializing GitHub API with:\n',
tokenlessArgs
);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

y'all should move to 120 chars BTW :P

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For prettier? I'll take a look at what that looks like tonight. The default is nice for side by side editing on VSCode.

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Jan 4, 2019
@hipstersmoothie hipstersmoothie merged commit 3d256aa into intuit:master Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants