feat: add runPubGetOffline option #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mspb1g12
force-pushed
the
feat/offline-pub-get
branch
2 times, most recently
from
8018cb4 to
7065a5d
Compare
mspb1g12
force-pushed
the
feat/offline-pub-get
branch
from
7065a5d to
837daaa
Compare
blaugold
approved these changes
Jun 20, 2022
Salakar
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an option to run all pub gets offline, relying on pre-populated pub caches.
This is useful in our CI environment which has a locked down network. Ideally the
--offlineflag (and other pub get flags) should be passed frombootstrapthrough topub getbut this seems like the simpler change in the short run, though if that seems preferable I can look into how it might work.Another alternative could be
runPubGetOfflineInCIusing https://pub.dev/packages/ci to detect the CI environment which would be more useful but may be too specific a use-case.Type of Change
feat-- New feature (non-breaking change which adds functionality)fix-- Bug fix (non-breaking change which fixes an issue)!-- Breaking change (fix or feature that would cause existing functionality to change)refactor-- Code refactorci-- Build configuration changedocs-- Documentationchore-- Chore