Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement scoped changelogs #421

Merged
merged 4 commits into from
Nov 30, 2022
Merged

feat: implement scoped changelogs #421

merged 4 commits into from
Nov 30, 2022

Conversation

lesnitsky
Copy link
Contributor

No description provided.

@Salakar Salakar requested a review from blaugold November 17, 2022 13:33
@lesnitsky
Copy link
Contributor Author

for the context:

in flutterfire we have a bunch of firebase_ui_* packages and we want to have a separate changelog for all packages that start with this prefix.

@blaugold blaugold marked this pull request as ready for review November 18, 2022 08:43
Copy link
Collaborator

@blaugold blaugold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks basically good. I've cleaned up a few things, made CI pass and added docs.

@Salakar Salakar self-requested a review November 23, 2022 14:00

The path to the changelog file relative to the workspace root.

### `command/version/changelogs/scope`
Copy link
Contributor

@Salakar Salakar Nov 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think maybe we should have the same syntax as properties under select-package in melos run scripts?

Will allow all filter types then rather than just scope, and will be consistent with other areas

Should just be able to reuse most of the logic to do so?

Thoughts @blaugold?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! I think we should do that.

@blaugold blaugold merged commit f0eca8d into main Nov 30, 2022
@blaugold blaugold deleted the feat/scoped-changelogs branch November 30, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants