Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improper errored exit code propagation #527

Closed
1 task done
mrverdant13 opened this issue May 19, 2023 · 1 comment · Fixed by #762
Closed
1 task done

fix: improper errored exit code propagation #527

mrverdant13 opened this issue May 19, 2023 · 1 comment · Fixed by #762
Assignees
Labels
bug Something isn't working Type: Accepted

Comments

@mrverdant13
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues.

Version

3.0.1

Description

When a command is run for a set of packages with the exec option, if the command exits with a non-zero code, the melos CLI does not propagate the failure result with an errored exit code.

Steps to reproduce

  1. In a mono-repo with at least two packages.
  2. Create the melos.yaml file with the basic Melos setup.
  3. Define the following script:
    should-fail:
      description: A script that should fail.
      run: dart run absent_file.dart
      exec:
        concurrency: 1
        failFast: true
      packageFilters:
        scope: "*"
  4. Run melos run should-fail --no-select.

Expected behavior

When running melos run should-fail, Melos should stop the whole execution with an errored exit code.

Given that the absent_file.dart file does not exist, the actual Melos execution workflow is interrupted in the first package but Melos ends up printing a SUCCESS message.

Screenshots

image

Additional context and comments

  • OS: Windows
  • Dart: 3.0.0
  • Terminal: Git Bash
@mrverdant13 mrverdant13 added bug Something isn't working Needs: Triage The issue needs triaging labels May 19, 2023
@bvoq
Copy link

bvoq commented Aug 30, 2024

I have the same issue. Would be good if this can be fixed.
It also happens on macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Type: Accepted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants