Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request: log output is the same or similar even if the -c option of melos analyse is greater than or equal to 1 #668

Closed
1 task done
koji-1009 opened this issue Mar 20, 2024 · 1 comment · Fixed by #678

Comments

@koji-1009
Copy link
Contributor

Is there an existing feature request for this?

  • I have searched the existing issues.

Command

melos analyze

Description

The melos analyze command, added from v5, logs differently for -c 1 and -c 2.

-c 1 case

$ melos analyze -c 1
Building package executable...
Built melos:melos.
$ melos analyze
  └> dart analyze
     └> RUNNING (in 3 packages)

--------------------------------------------------------------------------------
conventional_commit:
Analyzing conventional_commit...
No issues found!
conventional_commit: SUCCESS
--------------------------------------------------------------------------------
melos:
Analyzing melos...
No issues found!
melos: SUCCESS
--------------------------------------------------------------------------------
melos_workspace:
Analyzing melos...
No issues found!
melos_workspace: SUCCESS
--------------------------------------------------------------------------------

$ melos analyze
  └> dart analyze
     └> SUCCESS

-c 2 case

$ melos analyze -c 2
Building package executable...
Built melos:melos.
$ melos analyze
  └> dart analyze
     └> RUNNING (in 3 packages)

--------------------------------------------------------------------------------
Analyzing conventional_commit...
Analyzing melos...
No issues found!
No issues found!
Analyzing melos...
No issues found!
--------------------------------------------------------------------------------

$ melos analyze
  └> dart analyze
     └> SUCCESS

It would be nice if the two were the same, or at least easier to understand SUCCESS per package.

Reasoning

In environments with many packages (e.g. plus_plugins), it is suitable to set many -c.
And because it is an environment with many packages, it is nice to have a log output that makes it easy to check the success or failure of each package.

Additional context and comments

No response

@jessicatarra
Copy link
Contributor

It's a logging output issue, the concurrency is actually working fine, but the logs are not being displayed properly to the user, showing the correct information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants