Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Azure DevOps repository #681

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

lrampazzo
Copy link
Contributor

@lrampazzo lrampazzo commented Mar 27, 2024

Description

Adds support for Azure DevOps repository URLs. Probably also supports hosted Team Foundation Server, but I haven't had a chance to check if everything works.

This will resolve #599

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

@CLAassistant
Copy link

CLAassistant commented Mar 27, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks for your contribution!
The code looks good, it's just a trailing comma that the analyzer complains at here:

  /home/runner/work/melos/melos/packages/melos/lib/src/common/git_repository.dart:298:67 Missing a required trailing comma.

And the CLA has to be signed, it seems like you don't have the e-mail you have signed the CLA with connected to your GitHub, so the merge that you did from the GitHub interface doesn't count as it has signed the CLA.
The easiest is probably to rebase your branch on main locally and force push (without pulling down the merge commit).

@spydon spydon enabled auto-merge (squash) March 27, 2024 20:31
@spydon spydon merged commit 16fc890 into invertase:main Mar 27, 2024
10 checks passed
@lrampazzo
Copy link
Contributor Author

Thanks for your great work guys! Keep it up!

@lrampazzo lrampazzo deleted the azure-devops branch March 27, 2024 20:38
@kaelodd
Copy link

kaelodd commented Dec 23, 2024

hello @lrampazzo @CLAassistant @spydon @ryanhanks @

I have been trying to run the melos command in azure devops pipeline. I keep getting command not found
/home/vsts/work/_temp/a870e584-48c5-4176-9737-580c16ff2a46.sh: line 1: melos: command not found
##[error]Bash exited with code '127'.
or
You can fix that by adding this to your shell's config file (.bashrc, .bash_profile, etc.):

export PATH="$PATH":"$HOME/.pub-cache/bin"

Activated melos 3.4.0.
melos.yaml: SDK path is not valid. Could not find dart tool at /home/vsts/work/1/s/.fvm/flutter_sdk/bin/dart
pub finished with exit code 1

after running this export PATH="$PATH":"$HOME/.pub-cache/bin"

it still fails. can someone guide me on how they successsfully make the melos command works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request: support for Azure Devops repo
4 participants