Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: changelogFormat configuration, add includeDate boolean #720

Merged
merged 10 commits into from
Jun 5, 2024

Conversation

mzdm
Copy link
Contributor

@mzdm mzdm commented Jun 2, 2024

Description

Fixes #393.

I think adding it inside a map is better for the future. There can be settings like date format etc. includeCommitId etc. could be moved there in the future too

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@mzdm mzdm marked this pull request as draft June 2, 2024 15:23
@mzdm mzdm marked this pull request as ready for review June 2, 2024 16:04
Copy link
Collaborator

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one comment

@mzdm mzdm requested a review from spydon June 4, 2024 13:27
@mzdm mzdm requested a review from spydon June 4, 2024 15:09
@@ -26,6 +26,7 @@ dependencies:
glob: ^2.1.2
graphs: ^2.3.1
http: ^1.1.0
intl: ^0.19.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check which version that is pinned to flutter stable, this should not be higher than that one. I think it might be 0.18.3, but double check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on these tags of this commit flutter/flutter@8d54abf I would say 0.19.0 intl is integrated in Flutter version 3.22.0

Whether to include the date in the generated CHANGELOG.md. Defaults to `false`.

With enabled, changelog entry header will include the date in the `yyyy-MM-dd` format.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should have an empty line at the end of the markdown file (we really should add a markdown linter to the pipeline)

@spydon spydon merged commit fed343b into invertase:main Jun 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request: Add the possibility to show the version date in the changelog
2 participants