-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: changelogFormat
configuration, add includeDate
boolean
#720
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one comment
# Conflicts: # docs/configuration/overview.mdx
@@ -26,6 +26,7 @@ dependencies: | |||
glob: ^2.1.2 | |||
graphs: ^2.3.1 | |||
http: ^1.1.0 | |||
intl: ^0.19.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check which version that is pinned to flutter stable, this should not be higher than that one. I think it might be 0.18.3, but double check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on these tags of this commit flutter/flutter@8d54abf I would say 0.19.0 intl is integrated in Flutter version 3.22.0
docs/configuration/overview.mdx
Outdated
Whether to include the date in the generated CHANGELOG.md. Defaults to `false`. | ||
|
||
With enabled, changelog entry header will include the date in the `yyyy-MM-dd` format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should have an empty line at the end of the markdown file (we really should add a markdown linter to the pipeline)
Description
Fixes #393.
I think adding it inside a map is better for the future. There can be settings like date format etc.
includeCommitId
etc. could be moved there in the future tooType of Change
feat
-- New feature (non-breaking change which adds functionality)fix
-- Bug fix (non-breaking change which fixes an issue)!
-- Breaking change (fix or feature that would cause existing functionality to change)refactor
-- Code refactorci
-- Build configuration changedocs
-- Documentationchore
-- Chore