fix: Use text script rather than fixed script paths #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
spydon
approved these changes
Nov 14, 2024
|
@spydon Thanks for the approve. I have little time to improve this with some potential tests. If you think it's fine then I will mark this as ready. |
I think it's fine, it looks like it makes sense and I assume you've tested it manually. |
spydon
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
melosexecutable path could be changed due to environment updates. Using a text script and letting the configuration run in the terminal can reduce the pain of checking out these configurations into version control.Type of Change
fix-- Bug fix (non-breaking change which fixes an issue)