-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[request] CLI register page module to current router #119
Comments
@mhartington Thoughts? |
I'd like to avoid magic resolution like this. Maybe a flag to pass the router-module you'd like to use?
I do not think this will ever be perfect, as once tabs are used, the structure could be really unpredictable. I wonder if keeping it as it is, is the safest option, and let users move the router if they want to. Or maybe an flag to disable the router from being added to a router-module? |
@mhartington @dwieeb Thanks for reply. I understood.
I think
|
@mhartington @dwieeb This flug is
I think try to implement this. What do you think? |
@mhartington @dwieeb What do you think? Can I make a start in?? |
I think
ionic g pg
command should page module to current router.Now, all page module registered to
src/app/app-routing.module.ts
.For example:
in tabs template,
$ ionic g pg tab1/sample
registerSamplePageModule
tosrc/app/app-routing.module.ts
. I expect register tosrc/tab1/tab1.module.ts
.generate pipe
works like this.Thanks.
The text was updated successfully, but these errors were encountered: