Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): Send cookies on proxied requests #2151

Merged

Conversation

macdja38
Copy link
Contributor

@macdja38 macdja38 commented Nov 8, 2019

This sends cookies along with requests to proxied urls, brings the behaviour in line with what happens on iOS.

This is important for us as we change the html being served to the app based on the cookies.

@macdja38 macdja38 self-assigned this Nov 11, 2019
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jcesarmobile jcesarmobile changed the title Send cookies with proxied requests on Android fix(android): Send cookies on proxied requests Nov 12, 2019
@jcesarmobile jcesarmobile merged commit fbe0b9d into ionic-team:master Nov 12, 2019
@macdja38 macdja38 deleted the cookies-with-proxy-request branch January 8, 2020 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants