Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: cordova-plugin-swrve compatibility issue on iOS #2209

Closed
2 tasks
TCCJay opened this issue Nov 25, 2019 · 2 comments · Fixed by #2330
Closed
2 tasks

bug: cordova-plugin-swrve compatibility issue on iOS #2209

TCCJay opened this issue Nov 25, 2019 · 2 comments · Fixed by #2330

Comments

@TCCJay
Copy link

TCCJay commented Nov 25, 2019

Bug Report

Capacitor Version

npx cap doctor output:
Latest Dependencies:

@capacitor/cli: 1.3.0

@capacitor/core: 1.3.0

@capacitor/android: 1.3.0

@capacitor/ios: 1.3.0

Installed Dependencies:

@capacitor/cli 1.3.0

@capacitor/android 1.3.0

@capacitor/core 1.3.0

@capacitor/ios 1.3.0

Affected Platform(s)

  • [] Android
  • [o ] iOS
  • Electron
  • Web

Current Behavior

Throwing the compilation errors on iOS:
Property 'webview' not found on object of type 'CDViewController *' SwrvePlugin.m

Expected Behavior

Runs without compilation errors

Sample Code or Sample Application Repo

I don't have the sample code but the this link is probably a point of failure (https://github.com/ionic-team/capacitor/blob/master/ios/CapacitorCordova/CapacitorCordova/Classes/Public/CDVViewController.m)

Reproduction Steps

  1. Install cordova-plugin-swrve (2.0.1)
  2. npx cap sync
  3. run ios project

Other Technical Details

npm --version output:

node --version output:

pod --version output (iOS issues only):

Other Information

@TCCJay TCCJay changed the title cordova-plugin-swrve compatibility issue on iOS bug: cordova-plugin-swrve compatibility issue on iOS Nov 25, 2019
@jcesarmobile
Copy link
Member

I've sent a PR that avoids the build failure, but the plugin won't work, plugins that rely on CDVViewController won't work because Capacitor uses CAPBridgeViewController instead.

@ionitron-bot
Copy link

ionitron-bot bot commented Nov 13, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Capacitor, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants