Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The height of VirtualScroll may not be updated #11928

Closed
pikotea opened this issue Jun 5, 2017 · 3 comments
Closed

The height of VirtualScroll may not be updated #11928

pikotea opened this issue Jun 5, 2017 · 3 comments

Comments

@pikotea
Copy link
Contributor

pikotea commented Jun 5, 2017

Ionic version: (check one with "x")
[ ] 1.x (For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[x] 3.x

I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/

Current behavior:
In my application, I use VirtualScroll and infiniteScroll.
Occasionally the height of VirtualScroll will not be updated and the following record may be hidden.

Related code:

https://github.com/ionic-team/ionic/blob/master/src/components/virtual-scroll/virtual-util.ts#L533

In the current code, the height of VirtualScroll is mother number of denominator. Then, as the height becomes very high, the response to the update of the height becomes bad.

The situation in my application is as follows.

  • lastCell.record: 135
  • totalRecords: 143
  • percentToBottom: 0.9507042253521126

percentToBottom > .995 => false

  • newHeight: 33356
  • diff: 4408
  • difference: 0.25 (fixed value)

diff > (newHeight * difference) => false

Despite the addition of 4408px in height, the height of VirtualScroll did not change.

@jgw96
Copy link
Contributor

jgw96 commented Jun 5, 2017

Hello, thanks for using Ionic! I am going to close this issue as a duplicate of #9765

@jgw96 jgw96 closed this as completed Jun 5, 2017
@pikotea
Copy link
Contributor Author

pikotea commented Jun 5, 2017

@jgw96 Thanks for your response. But, this issue is different #9765. This problem is occurring in ionic 3.3. Please confirm again.

I am sorry that English is not good and it is difficult to understand. ;-)

vs

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 2, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants