Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swipeBackEnabled="true" opens menu and pops a page simultaneously #6508

Closed
ghost opened this issue May 12, 2016 · 2 comments
Closed

swipeBackEnabled="true" opens menu and pops a page simultaneously #6508

ghost opened this issue May 12, 2016 · 2 comments

Comments

@ghost
Copy link

ghost commented May 12, 2016

Short description of the problem:

Not exactly sure if this is intended or not, but I looked through the open and closed issues and I didn't find anything that came close...

Problem
When swipeBackEnabled="true" on <ion-nav>,
swiping back goes back one page, and opens the sidemenu.
(Happens in both iOS and Android)

What behavior are you expecting?

I would expect that either:

  • if there are pages on the nav stack, that it goes back one page (equivalent of nav.pop()). If there are no pages (e.g. on root page) the sidemenu would open; or
  • regardless of the amount of pages on the stack, it would open the sidemenu.

However, I think that the intended design is not for both to happen at the same time!!

Steps to reproduce:

  1. ionic start test sidemenu --ts --v2
  2. cd test && ionic serve --lab
  3. change swipeBackEnabled="false" to swipeBackEnabled="true" in app.html
  4. go to the list page, put more than one page on the stack (clicking on items), and then attempt to swipe back one page.

Here's the Plunker
http://plnkr.co/edit/LZ8z52vixMr5lIDbPLg6?p=preview
This Plunker demonstrates an Android (Material Design) template, I would recommend looking at iOS as well as the issue it much easier to see with iOS's swipe back animation.

Which Ionic Version? 2.x

Cordova CLI: 6.1.1
Ionic Framework Version: 2.0.0-beta.6
Ionic CLI Version: 2.0.0-beta.25
Ionic App Lib Version: 2.0.0-beta.15
ios-deploy version: 1.8.6
ios-sim version: 5.0.8
OS: Mac OS X El Capitan
Node Version: v4.4.3
Xcode version: Xcode 7.3.1 Build version 7D1014
@Manduro
Copy link
Contributor

Manduro commented May 13, 2016

Duplicate of #5575

@brandyscarney
Copy link
Member

Thanks @Manduro. Closing as a duplicate of #5575, but thanks for the issue @callodacity!

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants