Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apollo library not working in RC0 (rollup+commonjs circular dep issue) #8400

Closed
chriswep opened this issue Oct 2, 2016 · 2 comments
Closed

Comments

@chriswep
Copy link

chriswep commented Oct 2, 2016

I used the library apollo-client successfully before RC0 in an ionic project. Now the runtime crashes as soon as i import from the apollo library:

Uncaught TypeError: Cannot read property 'HTTPFetchNetworkInterface' of undefined (anonymous function) @ batchedNetworkInterface.js:75

I digged into this already and it very much looks like this is a problem due to rollup+commonjs, as is also seen with other libraries. In the case of apollo this looks like a circular dependency that the rollup commonjs plugin just can't handle (rollup/rollup-plugin-commonjs#105).

I wonder how the ionic project wants to deal with this? If Rollup isn't compatible with a lot of existing important libraries, i wonder if it is a good fit for a general purpose framework like Ionic? Maybe the good approach of rollup can be combined with some compatibility as suggested in this comment in a similar issue: #8356 (comment)

@jgw96
Copy link
Contributor

jgw96 commented Oct 3, 2016

This issue was moved to ionic-team/ionic-app-scripts#67

@jgw96
Copy link
Contributor

jgw96 commented Oct 3, 2016

Hello, thanks for opening an issue with us! Since this is a build related issue i have moved this to the app-scripts repo. Thanks for using Ionic!

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants