Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lerna): downgrade lerna for now #25497

Merged
merged 1 commit into from
Jun 17, 2022
Merged

chore(lerna): downgrade lerna for now #25497

merged 1 commit into from
Jun 17, 2022

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Jun 17, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

According to https://github.com/lerna/lerna/releases/tag/v5.0.0, we should be fine to upgrade to lerna v5. Our CI is not impacted by the Node version breaking changes, and we should be fine with the @npmcli/run-script changes (we make use of prepublishOnly, but that appears to still be part of the API).

What is the new behavior?

The error log is pretty minimal, so until I can dig more into this I am going to revert the Lerna change for now.

At first glance, it appears that Lerna 5 is running multiple builds in parallel, which is not what we need. Since Ionic angular server depends on Ionic angular, we need Ionic angular to build first. More investigation is needed.

We are possibly running into this bug: lerna/lerna#3146

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi marked this pull request as ready for review June 17, 2022 13:58
@liamdebeasi liamdebeasi requested a review from a team as a code owner June 17, 2022 13:58
@liamdebeasi liamdebeasi merged commit 719091f into main Jun 17, 2022
@liamdebeasi liamdebeasi deleted the downgrade-lerna branch June 17, 2022 14:12
@JamesHenry
Copy link
Contributor

Hi @liamdebeasi, I'm one of the new maintainers of Lerna via Nrwl - I'm sorry to see you had an issue that required you to downgrade.

Please can we work together to get you folks back on the latest version?

Maybe you could ping me on the Nrwl community slack so we can figure out some next steps: https://go.nrwl.io/join-slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants