feat(icon): support for dynamic type #1246
Conversation
|
Should this target a different branch instead of |
Yes, it should target "FW-4146" branch instead of main. |
There was a problem hiding this comment.
Can we add a screenshot test of icon being used with the text scaled up? Here's an example you can follow: https://github.com/ionic-team/ionic-framework/pull/27848/files#diff-2796ab1a929613b79f68ba352b11a68994e442070db3a7bbdbd7a1c0ded56c47R9-R26
(Note: previously the team discussed using a linter to ensure rem usage, but as I got more into development I realized some of these components are a bit more in-depth than I initially thought, so to be safe we're going to add a screenshot test)
|
@thetaPC it looks like the |
|
Oops, I misspoke. I though this was on the Framework repo. Disregard my comment. |
There was a problem hiding this comment.
Any idea why this screenshot changed?
There was a problem hiding this comment.
Unsure why it continues to show as a diff. I originally ran the screenshot job before updating the styles to have the font size on html instead of body.
I'll try reverting the diff and see if CI passes.
Converts the usage of px units for fonts to rem.