Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSI cannot be opened if is called after Vim no-file start (Windows x64) #17

Closed
cpkio opened this issue Oct 18, 2019 · 5 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@cpkio
Copy link

cpkio commented Oct 18, 2019

Installed language client and Vim_Fsharp yesterday, so vesions are up-to-date.

Problem Description
When Vim is started without a file (vim.exe), and .fs is loaded via :e command, FSI cannot be called (with <leader>e) with error message of

Error detected while processing function fsharp#toggleFsi:
line 7:                                                
E444: Cannot close last window                            

If Vim is started with a file name (vim somefile.fs), FSI opens normally. This affects both Vim and GVim.

:FsiShow command doesnt work anyway with E119: Not enough arguments for function: fsharp#openFsi error.

This has been tested with a blank Vim8.1 Windows installation with only LANGUAGECLIENT-NEOVIM and VIM_FSHARP_LANGUAGECLIENT installed.

To Reproduce
Steps to reproduce the behaviour:

  1. start vim from the command line with no file option
  2. load a file via :e
  3. try to open an FSI console with <leader>e and get a
Error detected while processing function fsharp#toggleFsi:
line 7:                                                
E444: Cannot close last window                            
  1. try to run :FsiShow command and get E119: Not enough arguments for function: fsharp#openFsi error.
  2. Start vim file.fs and see <leader>e working fine. :FsiShow wont work anyway.

Environment (please complete the following information):

  • OS: Windows 10 x64
  • Vim / Neovim version: 8.1x64 (2018 May 18)
  • dotnet SDK version: 3.0.100
@cpkio cpkio added the bug Something isn't working label Oct 18, 2019
@cannorin
Copy link
Member

Reproduced in my environment.

@cpkio
Copy link
Author

cpkio commented Oct 21, 2019

This commit didnt fix it for me, everything's the same.

@cannorin
Copy link
Member

Make sure you updated the plugin correctly, as FsiShow will at least give you a different error.

@cannorin cannorin reopened this Oct 21, 2019
@cpkio
Copy link
Author

cpkio commented Oct 21, 2019

I have to apologize. This happened because of Pathogen package «manager», which somehow messed with Ionide. Everything's fine now.

@cpkio cpkio closed this as completed Oct 21, 2019
@cannorin
Copy link
Member

Great to hear that it's now working correctly. Thanks for reporting 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants