Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Implement logic to allow tx or not based on mana cost for the X slots #7975

Closed
begonaalvarezd opened this issue Feb 2, 2024 · 1 comment · Fixed by #8139
Closed
Assignees

Comments

@begonaalvarezd
Copy link
Member

begonaalvarezd commented Feb 2, 2024

Task description

Price per block increases linearly with number of slots, so the formula to be used for the safe-buffer is really just

extraMana = numberOfSlots * protocolParams.CongestionControlParameters().Increase * blockWorkScore

That will give you the increase in maximum possible increase in Mana cost over numberOfSlots

Todos:

  • Calculate extra mana for the next 3 slots and add it on top of the mana cost
  • When 3 slots pass, re-calculate
  • Disable send button if there isnt enough available mana
@begonaalvarezd begonaalvarezd moved this from 📋 Backlog to 🔖 Todo in Firefly - Task Management Feb 2, 2024
@begonaalvarezd begonaalvarezd moved this from 🔖 Todo to 🚫 Blocked in Firefly - Task Management Feb 2, 2024
@begonaalvarezd begonaalvarezd moved this from 🚫 Blocked to 🔖 Todo in Firefly - Task Management Feb 5, 2024
@begonaalvarezd begonaalvarezd moved this from 🔖 Todo to 🚫 Blocked in Firefly - Task Management Feb 15, 2024
@begonaalvarezd
Copy link
Member Author

@cpl121 lets caluclate the buffer for the next 3 slots, and after that we have to update and recalculate the buffer again, and so like that

@cpl121 cpl121 moved this from 🚫 Blocked to 🔖 Todo in Firefly - Task Management Mar 5, 2024
@cpl121 cpl121 moved this from 🔖 Todo to 🏗 In Progress in Firefly - Task Management Mar 6, 2024
@cpl121 cpl121 self-assigned this Mar 6, 2024
@cpl121 cpl121 linked a pull request Mar 6, 2024 that will close this issue
10 tasks
@cpl121 cpl121 moved this from 🏗 In Progress to 👀 Needs Review in Firefly - Task Management Mar 6, 2024
@evavirseda evavirseda moved this from 👀 Needs Review to 📝 Changes Requested in Firefly - Task Management Mar 18, 2024
@cpl121 cpl121 moved this from 📝 Changes Requested to 👀 Needs Review in Firefly - Task Management Mar 18, 2024
@evavirseda evavirseda moved this from 👀 Needs Review to ✅ PR Approved in Firefly - Task Management Mar 18, 2024
@github-project-automation github-project-automation bot moved this from ✅ PR Approved to 🎉 Done in Firefly - Task Management Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎉 Done
Development

Successfully merging a pull request may close this issue.

2 participants