Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit block signing event with signing input #2054

Closed
Thoralf-M opened this issue Feb 23, 2024 · 1 comment · Fixed by #2100
Closed

Emit block signing event with signing input #2054

Thoralf-M opened this issue Feb 23, 2024 · 1 comment · Fixed by #2100
Labels
m-wallet Module - Wallet
Milestone
v2.0.0 (Q1 2024)

Comments

@Thoralf-M
Copy link
Member

Thoralf-M commented Feb 23, 2024 •
edited
Loading

So the signing_input can be displayed in Firefly for ledger nano, similar to TransactionProgressEvent::PreparedTransactionSigningHash

We should probably also change the numbers of the TransactionProgress events so they match the order we emit them (SigningTransaction before PreparedTransactionSigningHash/PreparedTransaction)

iota-sdk/sdk/src/wallet/operations/transaction/sign_transaction.rs

Line 39 in 2362363

TransactionProgressEvent::SigningTransaction,

@Thoralf-M Thoralf-M added the m-wallet Module - Wallet label Feb 23, 2024
@Thoralf-M Thoralf-M added this to the v2.0.0 (Q1 2024) milestone Feb 23, 2024
@github-project-automation github-project-automation bot moved this to Product Backlog in iota-sdk Feb 23, 2024
This was referenced Feb 28, 2024
Closed
Merged
@thibault-martinez
Copy link
Member

Closed by #2100

@github-project-automation github-project-automation bot moved this from Product Backlog to Done in iota-sdk Mar 5, 2024
@thibault-martinez thibault-martinez linked a pull request Mar 5, 2024 that will close this issue
feat: Wallet events improvements #2100
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
m-wallet Module - Wallet
Projects
iota-sdk
Status: Done
Milestone
v2.0.0 (Q1 2024)
Development

Successfully merging a pull request may close this issue.

feat: Wallet events improvements boxfish-studio/iota-sdk
2 participants
@thibault-martinez @Thoralf-M