Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

ipfs.add is not a function #301

Closed
chpio opened this issue Jun 21, 2016 · 7 comments
Closed

ipfs.add is not a function #301

chpio opened this issue Jun 21, 2016 · 7 comments
Labels

Comments

@chpio
Copy link

chpio commented Jun 21, 2016

im on v6.0.1

@daviddias daviddias added the bug label Jun 24, 2016
@harlantwood
Copy link
Contributor

harlantwood commented Jul 1, 2016

I'm getting the same issue. worked fine on 4.1.0, but missing in 6.0.1.

Also seems to be missing from the API docs: https://github.com/ipfs/js-ipfs-api/blob/master/API.md . In the API docs there is an add within the Extensions section, though its tests link points to a page that does not exist: https://github.com/ipfs/js-ipfs-api/blob/master/test/api/add.spec.js

@harlantwood
Copy link
Contributor

harlantwood commented Jul 1, 2016

Narrow version range: add works in 4.1.1, missing in 5.0.1

@harlantwood
Copy link
Contributor

Maybe related to #279

@nginnever
Copy link
Contributor

nginnever commented Jul 1, 2016

Hey @harlantwood!

We did change the way add is interfaced as you see in #279

@noffle added an alias here but it's not working. Going to look into it

@nginnever
Copy link
Contributor

nginnever commented Jul 1, 2016

Opened a PR that will allow for add to be called with or without files until the namespaces are ironed out.

@harlantwood
Copy link
Contributor

Thanks @nginnever!

@daviddias
Copy link
Contributor

Fixed on #309. Reopen as necessary.

Thank you @nginnever :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants