Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smarter Download Button #90

Closed
lidel opened this issue Feb 2, 2021 · 0 comments · Fixed by #92
Closed

Smarter Download Button #90

lidel opened this issue Feb 2, 2021 · 0 comments · Fixed by #92
Labels
need/triage Needs initial labeling and prioritization

Comments

@lidel
Copy link
Member

lidel commented Feb 2, 2021

Right now Download always downloads .tar archive with all shared files.

This is cool for directories and multiple files, but annoying when a single file is shared.
In that case there is no need to wrap single file in an archive – user should fetch it directly.

I think we should detect when only one file is shared, and make it either (TBD):

  • do the download via ipfs.cat
  • link to it directly with https://ipfs.io/ipfs/{cid}?filename={name}&download=true parameter, which will trigger download via content-disposition HTTP header
@lidel lidel added the need/triage Needs initial labeling and prioritization label Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant