From 3dca97c32dd064f8cc6c2b47fe5af853c9d2710f Mon Sep 17 00:00:00 2001
From: Jorropo <jorropo.pgm@gmail.com>
Date: Mon, 15 Jan 2024 07:42:36 +0100
Subject: [PATCH] blockservice: optimize getBlocks filter by not rescanning the
 already valid leading elements

We would scan the valid leading elements twice.
---
 blockservice/blockservice.go | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/blockservice/blockservice.go b/blockservice/blockservice.go
index b9041a431c..8523469af4 100644
--- a/blockservice/blockservice.go
+++ b/blockservice/blockservice.go
@@ -367,25 +367,25 @@ func getBlocks(ctx context.Context, ks []cid.Cid, blockservice BlockService, fet
 		allowlist := grabAllowlistFromBlockservice(blockservice)
 		blocker := grabBlockerFromBlockservice(blockservice)
 
-		allValid := true
-		for _, c := range ks {
+		var lastAllValidIndex uint
+		for ; lastAllValidIndex < uint(len(ks)); lastAllValidIndex++ {
+			c := ks[lastAllValidIndex]
 			if err := verifcid.ValidateCid(allowlist, c); err != nil {
-				allValid = false
 				break
 			}
 
 			if blocker != nil {
 				if err := blocker(c); err != nil {
-					allValid = false
 					break
 				}
 			}
 		}
 
-		if !allValid {
+		if lastAllValidIndex != uint(len(ks)) {
 			// can't shift in place because we don't want to clobber callers.
-			ks2 := make([]cid.Cid, 0, len(ks))
-			for _, c := range ks {
+			ks2 := make([]cid.Cid, lastAllValidIndex, len(ks))
+			copy(ks2, ks[:lastAllValidIndex])          // fast path for already filtered elements
+			for _, c := range ks[lastAllValidIndex:] { // don't rescan already scanned elements
 				// hash security
 				if err := verifcid.ValidateCid(allowlist, c); err != nil {
 					logger.Errorf("unsafe CID (%s) passed to blockService.GetBlocks: %s", c, err)