Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ipfs/go-bitswap] update go-lipb2p #72

Closed
marten-seemann opened this issue Aug 20, 2022 · 3 comments
Closed

[ipfs/go-bitswap] update go-lipb2p #72

marten-seemann opened this issue Aug 20, 2022 · 3 comments
Labels
need/triage Needs initial labeling and prioritization

Comments

@marten-seemann
Copy link
Member

marten-seemann commented Aug 20, 2022

This repo should be updated to use go-libp2p v0.22.0 (which deprecates go-libp2p-core).

The main change that needs to happen (other than a rewrite of import paths) is a change of this test: https://github.com/ipfs/go-bitswap/blob/4e3736a773545bf09d5178a2be24043b76560f87/network/ipfs_impl_test.go#L501-L516

The stream notifications were removed from the Notifiee interface a while ago: libp2p/go-libp2p-core#250

@marten-seemann marten-seemann added the need/triage Needs initial labeling and prioritization label Aug 20, 2022
@welcome
Copy link

welcome bot commented Aug 20, 2022

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

@Jorropo Jorropo changed the title update go-lipb2p [ipfs/go-bitswap] update go-lipb2p Jan 27, 2023
@Jorropo Jorropo transferred this issue from ipfs/go-bitswap Jan 27, 2023
@welcome
Copy link

welcome bot commented Jan 27, 2023

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

@Jorropo
Copy link
Contributor

Jorropo commented May 19, 2023

it has been done since

@Jorropo Jorropo closed this as completed May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Development

No branches or pull requests

2 participants