From 4216e2813a74a8da07ed89c9bba6208f9ae121d1 Mon Sep 17 00:00:00 2001 From: Steven Allen Date: Mon, 6 May 2019 10:29:30 -0700 Subject: [PATCH 1/3] default cidv1 to base32 --- cidenc/encoder.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cidenc/encoder.go b/cidenc/encoder.go index 6b8cefd..83ef016 100644 --- a/cidenc/encoder.go +++ b/cidenc/encoder.go @@ -14,7 +14,7 @@ type Encoder struct { // Default return a new default encoder func Default() Encoder { - return Encoder{Base: mbase.MustNewEncoder(mbase.Base58BTC)} + return Encoder{Base: mbase.MustNewEncoder(mbase.Base32)} } // Encode encodes the cid using the parameters of the Encoder From 2f1a02b4a5fdf2b6680b65fabb54ba871013bb2a Mon Sep 17 00:00:00 2001 From: Steven Allen Date: Mon, 6 May 2019 10:47:32 -0700 Subject: [PATCH 2/3] nit: gofmt --- format_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/format_test.go b/format_test.go index e102e7a..7bbefe9 100644 --- a/format_test.go +++ b/format_test.go @@ -96,7 +96,7 @@ bafybeietjgsrl3eqpqpcabv3g6iubytsifvq24xrrhd3juetskltgq7dja. offset := 0 for len(buf) > 0 { _, j, _, cidStr := ScanForCid(buf) - if cidStr != "" && cids[idx] != cidStr { + if cidStr != "" && cids[idx] != cidStr { t.Fatalf("Scan failed, expected %s, got %s (idx=%d offset=%d)", cids[idx], cidStr, idx, offset) } buf = buf[j:] From 6927839e80f7708a865033a0fe88d84576991765 Mon Sep 17 00:00:00 2001 From: Steven Allen Date: Mon, 6 May 2019 16:04:54 -0700 Subject: [PATCH 3/3] test default encoder --- cidenc/encoder_test.go | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/cidenc/encoder_test.go b/cidenc/encoder_test.go index a42ef34..225aa1f 100644 --- a/cidenc/encoder_test.go +++ b/cidenc/encoder_test.go @@ -59,4 +59,12 @@ func TestCidEncoder(t *testing.T) { testRecode(enc, cidv0str, cidb32str) testRecode(enc, cidv1str, cidb32str) testRecode(enc, cidb32str, cidb32str) + + enc = Default() + testEncode(enc, cidv0, cidv0str) + testEncode(enc, cidv1, cidb32str) + testRecode(enc, cidv0str, cidv0str) + testRecode(enc, cidv1str, cidb32str) + testRecode(enc, cidb32str, cidb32str) + }