add node to dagserv under lock

Otherwise, we could run a GC between adding and pinning. License: MIT Signed-off-by: Steven Allen <[email protected]>
ipfs · Dec 4, 2017 · 953b610 · 953b610
1 parent 8e780d2
commit 953b610
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/pin/pin.go b/pin/pin.go
@@ -172,7 +172,10 @@ func NewPinner(dstore ds.Datastore, serv, internal mdag.DAGService) Pinner {
 func (p *pinner) Pin(ctx context.Context, node node.Node, recurse bool) error {
 	p.lock.Lock()
 	defer p.lock.Unlock()
-	c := node.Cid()
+	c, err := p.dserv.Add(node)
+	if err != nil {
+		return err
+	}
 
 	if recurse {
 		if p.recursePin.Has(c) {