Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object put: Allow empty objects #6330

Merged
merged 3 commits into from
May 14, 2019
Merged

object put: Allow empty objects #6330

merged 3 commits into from
May 14, 2019

Conversation

magik6k
Copy link
Member

@magik6k magik6k commented May 14, 2019

Fixes #1331

License: MIT
Signed-off-by: Łukasz Magiera <[email protected]>
@Stebalien
Copy link
Member

See: 4430731. I ran into trouble detecting mis-encoded XML objects.

@magik6k
Copy link
Member Author

magik6k commented May 14, 2019

If we really want to be correct on how we parse xml, we'd probably want to use xml.Decoder directly, but I'm not sure if it's worth the time in this case

@Stebalien
Copy link
Member

If we really want to be correct on how we parse xml, we'd probably want to use xml.Decoder directly, but I'm not sure if it's worth the time in this case

Probably not. Want to just drop that test? However, I would backport my JSON error checking into this patch.

Stebalien and others added 2 commits May 14, 2019 23:37
License: MIT
Signed-off-by: Łukasz Magiera <[email protected]>
License: MIT
Signed-off-by: Łukasz Magiera <[email protected]>
@magik6k
Copy link
Member Author

magik6k commented May 14, 2019

(done)

@Stebalien Stebalien merged commit 942760b into master May 14, 2019
@Stebalien Stebalien deleted the fix/obj-put-empty branch May 14, 2019 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ipfs object put should accept empty objects
2 participants