Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include name in node.Link #61

Closed
dirkmc opened this issue May 8, 2019 · 2 comments
Closed

Include name in node.Link #61

dirkmc opened this issue May 8, 2019 · 2 comments

Comments

@dirkmc
Copy link

dirkmc commented May 8, 2019

When creating the set of node.Links, the name is not included

There is a test for this issue in interface-js-ipfs-core: https://github.com/ipfs/interface-js-ipfs-core/blob/master/src/object/links.js#L187
@dirkmc dirkmc mentioned this issue May 8, 2019
Merged
@Stebalien
Copy link
Member

See: ipfs/go-ipld-format#9. These links originally came from the "merkledag".

@dirkmc
Copy link
Author

dirkmc commented May 10, 2019

Ok thanks @Stebalien, I'll close this issue

@dirkmc dirkmc closed this as completed May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dirkmc @Stebalien