Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrap blockstore in identity blockstore #493

Merged
merged 1 commit into from
Apr 9, 2024
Merged

fix: wrap blockstore in identity blockstore #493

merged 1 commit into from
Apr 9, 2024

Conversation

achingbrain
Copy link
Member

Wraps blockstore to prevent writing identity blocks

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
fix: wrap blockstore in identity blockstore
34e0d5d 
Wraps blockstore to prevent writing identity blocks
@achingbrain achingbrain requested a review from a team as a code owner April 9, 2024 18:44
SgtPooki
SgtPooki approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL why helia was requesting identity CIDs from trustless-gateways.

@achingbrain achingbrain merged commit b67ac5f into main Apr 9, 2024
18 checks passed
@achingbrain achingbrain deleted the fix/update-blockstore-core branch April 9, 2024 18:59
@achingbrain achingbrain mentioned this pull request Apr 9, 2024
Merged
@SgtPooki SgtPooki mentioned this pull request Apr 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtPooki SgtPooki SgtPooki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achingbrain @SgtPooki