Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: blockstore operations should throw when passed an aborted signal #497

Merged
merged 1 commit into from
Apr 15, 2024
Merged

fix: blockstore operations should throw when passed an aborted signal #497

merged 1 commit into from
Apr 15, 2024

Conversation

achingbrain
Copy link
Member

If an aborted AbortSignal is passed to blockstore operations, the operation should throw an AbortError.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
fix: blockstore operations should throw when passed an aborted signal
6339ce3 
If an aborted `AbortSignal` is passed to blockstore operations, the
operation should throw an `AbortError`.
@achingbrain achingbrain requested a review from a team as a code owner April 15, 2024 11:18
@achingbrain achingbrain merged commit 9a10498 into main Apr 15, 2024
18 checks passed
@achingbrain achingbrain deleted the fix/abort-blockstore-operations-when-passed-aborted-signal branch April 15, 2024 13:11
@achingbrain achingbrain mentioned this pull request Apr 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@achingbrain