fix: log peer id as string not object #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we aren't logging buffers etc, log the peer id as a string when lookup fails.
SgtPooki
approved these changes
Apr 22, 2024
Merged
2color
reviewed
Apr 25, 2024
| @@ -89,15 +89,15 @@ export class Routing implements RoutingInterface, Startable { | |||
|
|
|||
| return provider | |||
| } catch (err) { | |||
| this.log.error('could not load multiaddrs for peer', peer.id, err) | |||
| this.log.error('could not load multiaddrs for peer %p', peer.id, err) | |||
There was a problem hiding this comment.
Custom libp2p logger formatter. Libp2p has a number of these for multiaddr, cid, peerid, etc..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we aren't logging buffers etc, log the peer id as a string when lookup fails.
Change checklist