Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display progress of Quick Upload #295

Closed
lidel opened this issue Oct 15, 2017 · 3 comments
Closed

Display progress of Quick Upload #295

lidel opened this issue Oct 15, 2017 · 3 comments
Labels
exp/intermediate Prior experience is likely helpful good first issue Good issue for new contributors help wanted Seeking public contribution on this issue status/ready Ready to be worked
Milestone

Comments

@lidel
Copy link
Member

lidel commented Oct 15, 2017

There should be some form of visual feedback when user is uploading a big file.

Adding a progress indicator should be possible when changes listed in ipfs-inactive/js-ipfs-http-client#608 are released 🤔

@lidel lidel added exp/intermediate Prior experience is likely helpful good first issue Good issue for new contributors help wanted Seeking public contribution on this issue P4 - Very Low labels Oct 15, 2017
@lidel lidel added this to the 2018-Q1 milestone Dec 2, 2017
@cvan
Copy link

cvan commented Mar 7, 2018

What ought to be the file-size recommendations/limits for file uploads?

@lidel lidel added the status/ready Ready to be worked label Mar 7, 2018
@lidel
Copy link
Member Author

lidel commented Mar 7, 2018

This remains an open question.

I suspect there will be different choke points depending on what IPFS node type is used:

  • If extension is set up to use external IPFS node, then we have potential transfer speed limits introduced by js-ipfs-api (HTTP API Client library) and then storage characteristics of go-ipfs come to play.
  • If embedded js-ipfs is used, then we have limits imposed by browser vendor on memory use and max local storage size per extension.

In addition to the above, if upload is performed via window.ipfs object, then there might be some overhead introduced by ipfs-postmsg-proxy.

Expect these specific setups to be benchmarked at some point, but looking at https://benchmark-js.ipfs.io I am rather optimistic about every day use.

@lidel
Copy link
Member Author

lidel commented May 24, 2018

Progress indicator shipped with v2.3.0. Works best with embedded nodem but external node users should also get some benefit.
There are remaining issues such as long buffering when external node is used, but these things will be addressed in upstream libraries.

@lidel lidel closed this as completed May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/intermediate Prior experience is likely helpful good first issue Good issue for new contributors help wanted Seeking public contribution on this issue status/ready Ready to be worked
Projects
None yet
Development

No branches or pull requests

2 participants