Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if Brave requires own build target #419

Closed
lidel opened this issue Mar 12, 2018 · 0 comments · Fixed by #609
Closed

Check if Brave requires own build target #419

lidel opened this issue Mar 12, 2018 · 0 comments · Fixed by #609
Assignees
@olizilla
Labels
kind/maintenance Work required to avoid breaking changes or harm to project's status quo status/ready Ready to be worked

Comments

@lidel
Copy link
Member

lidel commented Mar 12, 2018

Support for vendor-specific manifest.json landed in #416.

I am not familiar with any Brave-specific manifest keys, so this issue is (hopefully) just a quick chore to confirm that Brave works fine with build/generic/*.zip (assembled via bundle:generic).
@lidel lidel added the kind/maintenance Work required to avoid breaking changes or harm to project's status quo label Mar 12, 2018
@lidel lidel added the status/ready Ready to be worked label Jun 25, 2018
@lidel lidel mentioned this issue Oct 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olizilla olizilla

Labels
kind/maintenance Work required to avoid breaking changes or harm to project's status quo status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Official Support for Chromium-based Brave ipfs/ipfs-companion
2 participants
@olizilla @lidel