Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make room for window controls in left nav #1668

Closed
jessicaschilling opened this issue Oct 6, 2020 · 2 comments · Fixed by ipfs/ipfs-webui#1663
Closed

Make room for window controls in left nav #1668

jessicaschilling opened this issue Oct 6, 2020 · 2 comments · Fixed by ipfs/ipfs-webui#1663
Assignees
@jessicaschilling
Milestone
v0.14

Comments

@jessicaschilling
Copy link
Contributor

It's fine in Web UI, but in Desktop's standalone Electron window, the IPFS cube is too close to the window control buttons on a Mac. Margins were tightened to accommodate small screens in Web UI, so look into whether it's possible to restyle just for Electron standalone or if we need to add some additional margin universally.

image
@ipfs ipfs deleted a comment from welcome bot Oct 6, 2020
@jessicaschilling jessicaschilling self-assigned this Oct 6, 2020
@jessicaschilling jessicaschilling added this to the v0.14 milestone Oct 6, 2020
@jessicaschilling jessicaschilling mentioned this issue Oct 6, 2020
Closed
8 tasks
@lidel
Copy link
Member

lidel commented Oct 6, 2020 •
edited
Loading

@rafaelramalho19 just removed Electron-specific code in ipfs/ipfs-webui#1628, so I'd vote for adding margin in user-agent-agnostic way.

Perhaps narrow margin around logo could be maintained for small screens with something like @media only screen and (max-height: SOMEpx)?

@jessicaschilling jessicaschilling changed the title Look into Electron-only styling for left nav Make room for window controls in left nav Oct 6, 2020
@jessicaschilling jessicaschilling mentioned this issue Oct 6, 2020
Merged
@jessicaschilling
Copy link
Contributor Author

ipfs/ipfs-webui#1663 should take care of this (cc @lidel)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessicaschilling jessicaschilling

Labels
None yet
Projects
None yet
Milestone
v0.14
Development

Successfully merging a pull request may close this issue.

feat: better left navbar response at varying heights ipfs/ipfs-webui
2 participants
@lidel @jessicaschilling