Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop ask to control System Events on macOS on first run #753

Closed
olizilla opened this issue Dec 17, 2018 · 8 comments
Closed

Desktop ask to control System Events on macOS on first run #753

olizilla opened this issue Dec 17, 2018 · 8 comments
Labels

Comments

@olizilla
Copy link
Member

On first run on macOS, we get this dialog

screenshot 2018-12-17 at 11 22 13

We should see if we can remove the need for the System Events, as I don't think we're doing anything that directly needs it.

@hacdias
Copy link
Member

hacdias commented Dec 18, 2018

Did you always get that or it was after a specific commit? On Windows it doesn't need any special permission. It doesn't even ask for Administrator permission unless you install it for the whole system.

@olizilla
Copy link
Member Author

I get it when using desktop from the .dmg. I'll see what I can find out about it.

@fsdiogo
Copy link
Contributor

fsdiogo commented Dec 19, 2018

Before that I get this:
oops

We can easily open it by right-clicking the app icon on the Applications folder an click Open, but many people don't know about this.

Is there a plan to identify the app so the user doesn't get this?

@hacdias
Copy link
Member

hacdias commented Dec 19, 2018

@fsdiogo yes! #66 😄

@meiqimichelle
Copy link

+1 to @olizilla 's experience -- same thing happened to me, also downloaded as .dmg .

@pavel-lens
Copy link

+1.

Also, from UX perspective the app is opened in background and put into Mac menu bar. However, the app in launch bar is not opened (there is not a dot under the icon - indicating the app is opened). I tried to open the app multiple times till I realised that I can access the app from menu bar. It would be great to see at least a message every time you try to open the app saying "IPFS Desktop is already running. You can access the app from menu bar."

@hacdias
Copy link
Member

hacdias commented Dec 22, 2018

Well, we only allow one instance at a time and we tell the user if they try to launch Desktop more than one time. At least on Windows it is working, but I see macOS has different mechanisms. @olizilla @fsdiogo could you check that please?

@hacdias hacdias added the area/macos MacOS label Jan 6, 2019
@hacdias hacdias changed the title Desktop ask to contol System Events on macOS on first run Desktop ask to control System Events on macOS on first run Mar 12, 2019
@hacdias
Copy link
Member

hacdias commented Apr 9, 2019

Closing this: we will keep asking to control System Events, otherwise we can't add IPFS Desktop as a login item 😄 Source: https://github.com/Teamwork/node-auto-launch#applescript-default

Their alternative (Launch Agent) has some worse cons (such as leaving files behind when uninstalling).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants