Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve upload memory leaks #1488

Closed
rafaelramalho19 opened this issue May 8, 2020 · 1 comment
Closed

Resolve upload memory leaks #1488

rafaelramalho19 opened this issue May 8, 2020 · 1 comment
Assignees
@hugomrdias @achingbrain @rafaelramalho19
Labels
effort/days Estimated to take multiple days, but less than a week exp/expert Having worked on the specific codebase is important kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP status/ready Ready to be worked

Comments

@rafaelramalho19
Copy link
Contributor

Since it's not possible to split a file upload into multiple chunks, the memory usage while uploading files to the browser increases according to the size of the file (e.g. 1GB of file size -> 1GB of RAM used).

Since this limits our users from uploading files that are bigger than the remaining memory through WebUI, this is probably important for most users.

As discussed, a better alternative to HTTP uploads would be to use RPC.

Relevant participants:
@achingbrain
@hugomrdias
@Gozala
@rafaelramalho19 rafaelramalho19 added the P0 Critical: Tackled by core team ASAP label May 8, 2020
@jessicaschilling jessicaschilling added exp/expert Having worked on the specific codebase is important effort/days Estimated to take multiple days, but less than a week kind/bug A bug in existing code (including security flaws) status/ready Ready to be worked labels May 8, 2020
@lidel
Copy link
Member

lidel commented Sep 15, 2020

I believe this was fixed in #1534

@lidel lidel closed this as completed Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hugomrdias hugomrdias

@achingbrain achingbrain

@rafaelramalho19 rafaelramalho19

Labels
effort/days Estimated to take multiple days, but less than a week exp/expert Having worked on the specific codebase is important kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@lidel @hugomrdias @achingbrain @jessicaschilling @rafaelramalho19