Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve file add so it can handle gigs of data #1529

Closed
Gozala opened this issue Jun 25, 2020 · 4 comments · Fixed by #1534
Closed

Improve file add so it can handle gigs of data #1529

Gozala opened this issue Jun 25, 2020 · 4 comments · Fixed by #1534
Assignees
@Gozala
Labels
effort/weeks Estimated to take multiple weeks exp/wizard Extensive knowledge (implications, ramifications) required kind/enhancement A net-new feature or improvement to an existing feature need/analysis Needs further analysis before proceeding P0 Critical: Tackled by core team ASAP

Comments

@Gozala
Copy link
Contributor

Gozala commented Jun 25, 2020

This is related to ipfs/js-ipfs#3029, however changes on the webui end would also be required. So this is the placeholder issue for that piece of work.
@Gozala Gozala added the need/triage Needs initial labeling and prioritization label Jun 25, 2020
@Gozala

This comment has been minimized.

Sign in to view
@jessicaschilling

This comment has been minimized.

Sign in to view
@Gozala
Copy link
Contributor Author

Gozala commented Jun 25, 2020

Some notes (mostly for myself). Here's where dropped files are handled

https://github.com/ipfs-shipyard/ipfs-webui/blob/be316e50353d378778a610958af6643ff835946a/src/App.js#L109-L116

Which invokes addFiles

https://github.com/ipfs-shipyard/ipfs-webui/blob/be316e50353d378778a610958af6643ff835946a/src/App.js#L42-L53

Where array of web Files is converted to array of entries with content feilds are turned into streams of file contents. (This where we fall of optimal path and will end up having to buffer).

https://github.com/ipfs-shipyard/ipfs-webui/blob/be316e50353d378778a610958af6643ff835946a/src/lib/files.js#L4-L18

And then doFilesWrite uses ipfs.add to get those into IPFS via ipfs-http-client

https://github.com/ipfs-shipyard/ipfs-webui/blob/be316e50353d378778a610958af6643ff835946a/src/bundles/files/actions.js#L170-L207

@Gozala

This comment has been minimized.

Sign in to view
@lidel lidel added exp/wizard Extensive knowledge (implications, ramifications) required effort/weeks Estimated to take multiple weeks need/analysis Needs further analysis before proceeding P0 Critical: Tackled by core team ASAP kind/enhancement A net-new feature or improvement to an existing feature and removed need/triage Needs initial labeling and prioritization labels Jun 25, 2020
@Gozala Gozala mentioned this issue Jul 1, 2020
Merged
2 tasks
@Gozala Gozala mentioned this issue Aug 6, 2020
Merged
This was referenced Aug 20, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gozala Gozala

Labels
effort/weeks Estimated to take multiple weeks exp/wizard Extensive knowledge (implications, ramifications) required kind/enhancement A net-new feature or improvement to an existing feature need/analysis Needs further analysis before proceeding P0 Critical: Tackled by core team ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: file upload without buffering Gozala/ipfs-webui
3 participants
@Gozala @lidel @jessicaschilling