Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files: bogus link in onboarding materials #1530

Closed
lidel opened this issue Jun 25, 2020 · 4 comments · Fixed by #1531
Closed

Files: bogus link in onboarding materials #1530

lidel opened this issue Jun 25, 2020 · 4 comments · Fixed by #1531
Labels
area/screen/files Issues related to Files screen effort/hours Estimated to take one or several hours kind/bug A bug in existing code (including security flaws) P3 Low: Not priority right now topic/design-content Content design, writing, information architecture

Comments

@lidel
Copy link
Member

lidel commented Jun 25, 2020

Bug

When user opens Files screen and there are no files, onboarding materials are displayed.

Clicking on the link to "manage files" does nothing, because user is already on "Files" screen.

useless-self-link-2020-06-25--22-38-11

Ways to fix?

Quick fix is to remove the link, and update text to highlight that user is on the Files screen already.

It could be a good opportunity to audit/update these onboarding materials too (right now visible only when user has no files).

@lidel lidel added kind/bug A bug in existing code (including security flaws) P3 Low: Not priority right now area/screen/files Issues related to Files screen topic/design-content Content design, writing, information architecture effort/hours Estimated to take one or several hours labels Jun 25, 2020
@jessicaschilling
Copy link
Contributor

@lidel Can we just remove the link for now? We've got a handful of other open issues revolving around reworking the "no files here yet" page and moving some of its content into a proper welcome page.

@jessicaschilling
Copy link
Contributor

We could also replace "you can drag and drop" with "Drag and drop here ..." to make it clear that this is where you can put the files. (If that is indeed true when there aren't any files?)

@lidel
Copy link
Member Author

lidel commented Jun 25, 2020

I agree with both comments 👍 (Yes, user can drag&drop anywhere and it will work)

@jessicaschilling
Copy link
Contributor

#1531 fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/screen/files Issues related to Files screen effort/hours Estimated to take one or several hours kind/bug A bug in existing code (including security flaws) P3 Low: Not priority right now topic/design-content Content design, writing, information architecture
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants