Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permalinks with API Address #785

Closed
lidel opened this issue Sep 8, 2018 · 4 comments
Closed

Permalinks with API Address #785

lidel opened this issue Sep 8, 2018 · 4 comments
Labels
help wanted Seeking public contribution on this issue kind/discussion Topical discussion; usually not changes to codebase

Comments

@lidel
Copy link
Member

lidel commented Sep 8, 2018

Here's an idea: support for permalinks like this:

http://localhost:3000/#/settings?ipfsApi=http://127.0.0.1:5001

  • ?ipfsApi= is an optional parameter that overrides regular logic done by ipfs-redux-bundle
  • gives us ability to bookmark WebUIs for specific views for specific nodes :)
  • permalink could be under 🔗 icon on the "backend picker"
@olizilla
Copy link
Member

I can't tell if this is a harmless cool trick, or too much power to the link author

@olizilla
Copy link
Member

I left the configurability in the hands of the user via localStorage in ipld-explorer as I didn't feel comfortable adding url based configuration, though it did cross my mind. I can't think of a good malicious use case, but letting the link author choose what IPFS I connect to seems radical.

@lidel lidel added help wanted Seeking public contribution on this issue kind/discussion Topical discussion; usually not changes to codebase and removed question labels Sep 12, 2018
@olizilla olizilla removed the revamp label Sep 27, 2018
@lidel
Copy link
Member Author

lidel commented Sep 29, 2018

Update:

Due to the above, it is no longer needed, closing.

@lidel lidel closed this as completed Sep 29, 2018
@lidel
Copy link
Member Author

lidel commented Jan 28, 2019

PSA: resumed in #947

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Seeking public contribution on this issue kind/discussion Topical discussion; usually not changes to codebase
Projects
None yet
Development

No branches or pull requests

2 participants