breaking change: stats spec, spec repo, stream to value on files read #679
Conversation
ghost
assigned 
|
interface-ipfs-core changes merged and released. Have fun! :) |
|
Also, make sure to update js-ipfs ;) |
|
@diasdavid I'll update the interface-ipfs-core version here to try it out. |
|
@diasdavid the tests for STATS are passing ;) |
| @@ -68,7 +68,7 @@ | |||
| "eslint-plugin-react": "^7.5.1", | |||
| "go-ipfs-dep": "^0.4.13", | |||
| "gulp": "^3.9.1", | |||
| "interface-ipfs-core": "~0.41.0", | |||
|
@diasdavid anything missing here? |
|
CI is not happy. Mind checking what's up? Seems that a rebase is needed. |
hacdias
changed the title
README.md
Outdated
| - [repo](https://github.com/ipfs/interface-ipfs-core/tree/master/SPEC/REPO.md) | ||
| - [`ipfs.repo.gc([options, callback])`](https://github.com/ipfs/interface-ipfs-core/tree/master/SPEC/REPO.md#gc) | ||
| - [`ipfs.repo.stat([options, callback])`](https://github.com/ipfs/interface-ipfs-core/tree/master/SPEC/REPO.md#stat) | ||
| - [`ipfs.repo.version([callback])`](https://github.com/ipfs/interface-ipfs-core/tree/master/SPEC/REPO.md#version) |
There was a problem hiding this comment.
This should be under the Node Management to match the structure in interface-ipfs-core
hacdias
force-pushed
the
stats-spec
branch
5 times, most recently
from
6b954ba to
686617f
Compare
Everything seems to pass here except that the node wasn't spawned in 6 seconds so it failed. |
|
@diasdavid I'd like to see everything passing, but I'm getting a |
|
The "out of memory" issue started with the ipfsd-ctl update. Essentially what is happening is that WebPack is trying to bundle too much code (more than one version of ipfs-api) and that is crashing the whole process. There is a way to increase the amount of memory allocated. But the good way to do it is to avoid creating the issue. I'm going to merge this PR but will create a issue to track this. |
|
Thanks! |
Ref.: ipfs-inactive/interface-js-ipfs-core#208.