Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

chore: logs path & querystring for requests #796

Merged
merged 1 commit into from
Jun 29, 2018
Merged

Conversation

achingbrain
Copy link
Collaborator

Also maps 'Type' property from error responses

Also maps 'Type' property from error responses
@ghost ghost assigned achingbrain Jun 27, 2018
@ghost ghost added the in progress label Jun 27, 2018
@achingbrain
Copy link
Collaborator Author

Not sure why CI keeps failing, you'd have thought these changes would be fairly innocuous.

@achingbrain
Copy link
Collaborator Author

Looks like the browser tests are taking ages to run and eventually the job times out and gets killed.

@alanshaw alanshaw merged commit 4e55d19 into master Jun 29, 2018
@ghost ghost removed the in progress label Jun 29, 2018
@alanshaw alanshaw deleted the add-request-log branch June 29, 2018 10:37
@alanshaw
Copy link
Contributor

Not sure why CI keeps failing, you'd have thought these changes would be fairly innocuous.

Apparently not! Not that you'd know from CI, but in the browser res.req is not available so all requests are broken in 22.2.0. PR here #798 - please can has quick review?

danieldaf pushed a commit to danieldaf/js-ipfs-api that referenced this pull request Jul 21, 2018
Also maps 'Type' property from error responses
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants