Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add webrtc to supports #38

Merged
merged 2 commits into from
Jun 18, 2020
Merged

feat: add webrtc to supports #38

merged 2 commits into from
Jun 18, 2020

Conversation

hugomrdias
Copy link
Member

No description provided.

Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do this in https://github.com/libp2p/js-libp2p-utils instead?

@hugomrdias
Copy link
Member Author

Yhis can also be useful in ipfs and this repo already has the supports file, i would leave it here, but if you feel strongly about it we can definitely change it to libp2p.

@vasco-santos
Copy link
Member

It feels strange to me to add an ipfs dependency into a libp2p module. Also for this context, libp2p-webrtc-star already uses libp2p-utils as its dependency

@hugomrdias
Copy link
Member Author

ok, lets add it to libp2p-utils.
i will probably merge this here also, maybe be useful and its small.

@achingbrain
Copy link
Member

Can we just have this sort of thing in a generic i-can-has module? It's not really specific to ipfs or libp2p and would actually be useful outside of PL projects.

@vasco-santos
Copy link
Member

Can we just have this sort of thing in a generic i-can-has module? It's not really specific to ipfs or libp2p and would actually be useful outside of PL projects.

Yeah, ideally it would be to just use webrtcsupport module

@hugomrdias
Copy link
Member Author

You guys know my opinion about creating new repos, but I'll support whatever.
Just keep in mind the changes I did to the feature test.

Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's get this in?

@hugomrdias hugomrdias force-pushed the feat/webrtc-support branch from 7be87dc to e45e83e Compare June 18, 2020 15:31
@hugomrdias hugomrdias merged commit 8cca85d into master Jun 18, 2020
@hugomrdias hugomrdias deleted the feat/webrtc-support branch June 18, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants