fix: make timeouts stricter #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only really useful when you are setting unreasonably short timeouts - in tests for example. |
Sometimes a request can resolve before the timeout callback fires, this can be because the system is under load and the event loop is blocked. This change looks at the time taken by a request to resolve when deciding if it's timed out as well as setting a regular js timeout to catch inactive requests. It also removes the `timeout` option passed to `node-fetch` as it implements it's own timeout feature which results in two types of timeout error that can occur - ours and `node-fetch`'s.
achingbrain
force-pushed
the
fix/http-timeouts
branch
from
1ccc921 to
80ad169
Compare
hugomrdias
approved these changes
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes a request can resolve before the timeout callback fires, this can be because the system is under load and the event loop is blocked.
This change looks at the time taken by a request to resolve when deciding if it's timed out as well as setting a regular js timeout to catch inactive requests.
It also removes the
timeoutoption passed tonode-fetchas it implements it's own timeout feature which results in two types of timeout error that can occur - ours andnode-fetch's.