Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Cannot compile with Typescript Project #4029

Closed
johanneskares opened this issue Jan 26, 2022 · 6 comments
Closed

Cannot compile with Typescript Project #4029

johanneskares opened this issue Jan 26, 2022 · 6 comments

Comments

@johanneskares
Copy link

In my project in tsconfig.json when skipLibCheck is set to false or remove the option I can no longer compile the project and I get a bunch of error messages.

@welcome
Copy link

welcome bot commented Jan 26, 2022

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

@johnb8005
Copy link
Contributor

here's a link to a failing build: https://github.com/nexys-system/ipfs-infura-client/actions/runs/1753407843
(which is solved by setting skipLibCheck=false)

@achingbrain
Copy link
Member

ToJSON can probably be removed, after a quick search it seems it's not used anywhere - would you like to open a quick PR?

To fix the "cannot find namespace 'fs'" error you can add @types/node to your project as a dev dep.

You probably want skipLibCheck: true in general though, there are lots of modules in the dep tree whose types are broken.

@johnb8005
Copy link
Contributor

johnb8005 commented Jan 27, 2022

@achingbrain see #4031

@achingbrain
Copy link
Member

@johnb8005 that just removes the circular reference, I mean the whole type can go.

@johnb8005
Copy link
Contributor

@achingbrain just edited

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants