From 8c9aa49b1cdd97c1bfeb212c1e7d175fe657eb98 Mon Sep 17 00:00:00 2001 From: Alan Shaw Date: Tue, 9 Apr 2019 17:01:11 +0100 Subject: [PATCH 1/3] refactor: disable DHT Due to performance issues the DHT is disabled for the upcoming release, you can turn it on optionally but your mileage may vary. License: MIT Signed-off-by: Alan Shaw --- src/core/runtime/libp2p-nodejs.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core/runtime/libp2p-nodejs.js b/src/core/runtime/libp2p-nodejs.js index 4f11036a86..21e709b0f2 100644 --- a/src/core/runtime/libp2p-nodejs.js +++ b/src/core/runtime/libp2p-nodejs.js @@ -54,9 +54,9 @@ class Node extends libp2p { }, dht: { kBucketSize: 20, - enabled: true, + enabled: false, randomWalk: { - enabled: true + enabled: false } }, EXPERIMENTAL: { From c2dcf6282b9c6f12a806c1f9532f10111f9c27e3 Mon Sep 17 00:00:00 2001 From: Alan Shaw Date: Wed, 10 Apr 2019 16:47:03 +0100 Subject: [PATCH 2/3] fix: skip test for missing functionality License: MIT Signed-off-by: Alan Shaw --- test/core/interface.spec.js | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/test/core/interface.spec.js b/test/core/interface.spec.js index 8134ffc702..ba86cff1ae 100644 --- a/test/core/interface.spec.js +++ b/test/core/interface.spec.js @@ -101,13 +101,18 @@ describe('interface-ipfs-core tests', function () { skip: [ { name: 'should resolve an IPNS DNS link', - reason: 'TODO IPNS not implemented yet' + reason: 'TODO: IPNS resolve not yet implemented https://github.com/ipfs/js-ipfs/issues/1918' }, { name: 'should resolve IPNS link recursively', - reason: 'TODO IPNS not implemented yet' + reason: 'TODO: IPNS resolve not yet implemented https://github.com/ipfs/js-ipfs/issues/1918' + }, + { + name: 'should recursively resolve ipfs.io', + reason: 'TODO: ipfs.io dnslink=/ipns/website.ipfs.io & IPNS resolve not yet implemented https://github.com/ipfs/js-ipfs/issues/1918' } - ] + ], + only: ['should recursively resolve ipfs.io'] }) tests.name(CommonFactory.create({ From f70d20a92a1ad80ea1ce14b0da90569df334ee3b Mon Sep 17 00:00:00 2001 From: Alan Shaw Date: Wed, 10 Apr 2019 16:48:22 +0100 Subject: [PATCH 3/3] fix: skip test for missing functionality License: MIT Signed-off-by: Alan Shaw --- test/core/interface.spec.js | 3 +-- test/http-api/interface.js | 8 ++++++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/test/core/interface.spec.js b/test/core/interface.spec.js index ba86cff1ae..9a59921b61 100644 --- a/test/core/interface.spec.js +++ b/test/core/interface.spec.js @@ -111,8 +111,7 @@ describe('interface-ipfs-core tests', function () { name: 'should recursively resolve ipfs.io', reason: 'TODO: ipfs.io dnslink=/ipns/website.ipfs.io & IPNS resolve not yet implemented https://github.com/ipfs/js-ipfs/issues/1918' } - ], - only: ['should recursively resolve ipfs.io'] + ] }) tests.name(CommonFactory.create({ diff --git a/test/http-api/interface.js b/test/http-api/interface.js index c72a6529b5..a33309b6c3 100644 --- a/test/http-api/interface.js +++ b/test/http-api/interface.js @@ -81,11 +81,15 @@ describe('interface-ipfs-core over ipfs-http-client tests', () => { skip: [ { name: 'should resolve an IPNS DNS link', - reason: 'TODO IPNS not implemented yet' + reason: 'TODO: IPNS resolve not yet implemented https://github.com/ipfs/js-ipfs/issues/1918' }, { name: 'should resolve IPNS link recursively', - reason: 'TODO IPNS not implemented yet' + reason: 'TODO: IPNS resolve not yet implemented https://github.com/ipfs/js-ipfs/issues/1918' + }, + { + name: 'should recursively resolve ipfs.io', + reason: 'TODO: ipfs.io dnslink=/ipns/website.ipfs.io & IPNS resolve not yet implemented https://github.com/ipfs/js-ipfs/issues/1918' } ] })