Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fragmentation #136

Closed
daviddias opened this issue Dec 13, 2016 · 6 comments
Closed

Fragmentation #136

daviddias opened this issue Dec 13, 2016 · 6 comments
Labels
P0 Critical: Tackled by core team ASAP

Comments

@daviddias
Copy link
Member

daviddias commented Dec 13, 2016

TIL that there is a @haad/ipfsd-ctl. I don't understand why there is a need to create such a module, but it seems it has been going for a while, making it more than an experiment, but an actual fork/module available in NPM.

I very much disagree with this approach because it is clearly fragmenting the ecosystem set by creating yet another module that is not being tracked as a PR and doesn't show any future where that will happen, making us maintain 2 modules instead of one.

When the challenge on ipfs/js-ipfs#556 was launched, the proposal was exactly to reduce fragmentation and to make the launch of IPFS nodes more easily, but what I see that got created was another module, ipfs-daemon, which has its set of issues, which uses a module that is a fork of this one, namely @haad/ipfsd-ctl.

@haadcode can we converge all of these, it really doesn't help. Others are invited to provide their feedback, I might also be missing the value and apologize in advance if I'm doing so.

@daviddias
Copy link
Member Author

daviddias commented Dec 13, 2016

We can see on how one is getting behind
image

And the link in the npm package is pointing to the 'wrong' repo
image

@daviddias
Copy link
Member Author

Found this one too https://github.com/haadcode/ipfs-test-apis

@daviddias daviddias added the status/ready Ready to be worked label Dec 15, 2016
@daviddias daviddias added status/deferred Conscious decision to pause or backlog and removed status/ready Ready to be worked labels Jan 29, 2017
@daviddias
Copy link
Member Author

@haadcode we need to converge https://github.com/haadcode/js-ipfsd-ctl into this. What are the steps for that? What is stopping you from using the main one and maintaining a fork?

@haadcode
Copy link
Member

Short: 0.4.5.

Long:
The fork was originally done to have 0.4.5 go-ipfs bin in the chain of deps for Orbit (which needed pubsub).

So, to unravel all that, we need to merge ipfs-inactive/npm-go-ipfs-dep#18 and ipfs-inactive/npm-go-ipfs-dep#19 and release [email protected].

The other part is to merge #145 and release new version of ipfsd-ctl (this PR will make ipfs-daemon compatible with js-ipfsd-ctl). And after releasing 0.4.5 we should release ipfsd-ctl with the new go-ipfs-dep version.

That's all! :) Finally there 🎉 🎆

@daviddias
Copy link
Member Author

daviddias commented Feb 15, 2017

I see a breaking change proposed on #145 and no PRs to js-ipfs and js-ipfs-api that cope with that change, meaning that the poor soul that merges and releases would have to run and put up fires. Can we avoid this by preemptively having PRs that cope with the fixes so that no one is caught off guard?

@daviddias daviddias added status/ready Ready to be worked P0 Critical: Tackled by core team ASAP and removed status/deferred Conscious decision to pause or backlog status/ready Ready to be worked labels Oct 17, 2017
@daviddias
Copy link
Member Author

All done \o/

@ghost ghost removed the status/ready Ready to be worked label Oct 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Critical: Tackled by core team ASAP
Projects
None yet
Development

No branches or pull requests

2 participants