From d9825b6045fd7ab0ed50d1924ad09c86c95d1418 Mon Sep 17 00:00:00 2001 From: Marcin Rataj Date: Thu, 5 Jan 2023 18:16:32 +0100 Subject: [PATCH] feat: remove Bitswap.ProviderSearchDelay Ref. https://github.com/ipfs/kubo/issues/8807#issuecomment-1371351845 Closes #8807 --- core/node/bitswap.go | 2 +- docs/config.md | 12 ++++++++---- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/core/node/bitswap.go b/core/node/bitswap.go index 42b948f7520a..b9fbdbc28db2 100644 --- a/core/node/bitswap.go +++ b/core/node/bitswap.go @@ -22,7 +22,7 @@ const ( DefaultTaskWorkerCount = 8 DefaultEngineTaskWorkerCount = 8 DefaultMaxOutstandingBytesPerPeer = 1 << 20 - DefaultProviderSearchDelay = 1000 * time.Millisecond + DefaultProviderSearchDelay = 0 * time.Millisecond ) type bitswapOptionsOut struct { diff --git a/docs/config.md b/docs/config.md index aae2017d0a81..48403753a8ba 100644 --- a/docs/config.md +++ b/docs/config.md @@ -972,11 +972,15 @@ Type: `optionalInteger` (byte count, `null` means default which is 1MB) ### `Internal.Bitswap.ProviderSearchDelay` -This parameter determines how long to wait before looking for providers outside of bitswap. -Other routing systems like the DHT are able to provide results in less than a second, so lowering -this number will allow faster peers lookups in some cases. +Optional delay before looking for providers outside of bitswap, +using routers configured in [`Routing`](#routing) (e.g., DHT, IPNI). -Type: `optionalDuration` (`null` means default which is 1s) +Setting to `1s` may decrease the number of DHT and IPNI queries at the cost of +increased latency. It is advised to keep this unset unless you are confident +the most of requested data will be provided by [`Peering.Peers`](#peering) over +bitswap. More details in [kubo#8807](https://github.com/ipfs/kubo/issues/8807). + +Type: `optionalDuration` (`null` means default which is `0s`) ### `Internal.UnixFSShardingSizeThreshold`