-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mdns service string does not conform to convention. #2086
Comments
sure, think you could file a PR? |
Yeah, I'll give it a go. |
@NeoTeo is this part of an RFC? or this apple enforcing a standard themselves? i agree we want to make it easier, but not sure if we should be advertising in both. (though yes, mdns is more complicated than it needed to be >.< |
Yeah, RFC 6763 which follows conventions from RFC 2782. Agreed on mdns. |
@NeoTeo this has been resolved, right? |
@whyrusleeping Yes :) |
An IPFS node currently advertises itself as an mdns service using the string "discovery.ipfs.io" (in p2p/discovery/mdns.go) which, when listed, shows up on the network as
ipfs.local. discovery
This is different from the standard convention of a service type followed by a transport layer, separated by underscores. Eg. the Airplay and 1Password services show up as
_tcp.local. _airplay
_tcp.local. _1password4
In the case of Apple's Foundation frameworks the libs expect this format to be able to search for a particular service and I think the unconventional format is causing it to not be found when searching for the transport layer "ipfs".
Any chance we can use the standard convention (as described in the usage example at https://github.com/cryptix/mdns) in IPFS as well?
The text was updated successfully, but these errors were encountered: