-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove "testing" imports in files that do not end in _test.go
#637
Comments
not sure what we want to do about all the test utils. can |
On Fri, Jan 23, 2015 at 07:20:04PM -0800, Juan Batiz-Benet wrote:
I don't think they can. I'd like to move all shared test utilities I'm happy to start working on this, since cyclic imports bit me while |
$ egrep -r '"testing"' . | egrep -v "_test.go"
egrep: ./Godeps/_workspace/src/github.com/jbenet/go-multihash/test/sharness/bin: No such file or directory
./Godeps/_workspace/src/bazil.org/fuse/fs/fstestutil/mounted.go: "testing"
./Godeps/_workspace/src/github.com/jbenet/go-datastore/test/assert.go:import "testing"
./Godeps/_workspace/src/github.com/jbenet/go-datastore/test/test_util.go: "testing"
./Godeps/_workspace/src/github.com/jbenet/go-peerstream/muxtest/muxt.go: "testing"
./Godeps/_workspace/src/github.com/jbenet/go-stream-muxer/test/ttest.go: "testing"
./p2p/test/util/key.go: "testing"
./p2p/test/util/util.go: "testing"
./test/bench/bench_cli_ipfs_add/main.go: "testing"
./test/bench/offline_add/main.go: "testing"
./test/sharness/t0250-files-api.sh: echo "testing" | ipfs files write -f=false -e /cats/walrus
./thirdparty/assert/assert.go:import "testing"
./util/testutil/gen.go: "testing"
./util/testutil/identity.go: "testing" Seems all good now, closing :) |
These imports cause testing flags to be parsed in binaries that include
go-ipfs/core
.The text was updated successfully, but these errors were encountered: